fix: preserve SwiftPM resource bundle lookup in packaged app#2
Open
eggie-1988 wants to merge 1 commit intoHyperNoodlez:mainfrom
Open
fix: preserve SwiftPM resource bundle lookup in packaged app#2eggie-1988 wants to merge 1 commit intoHyperNoodlez:mainfrom
eggie-1988 wants to merge 1 commit intoHyperNoodlez:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Package the SwiftPM resource bundle in a way that still satisfies the generated
Bundle.modulelookup path used by the release executable.Problem
The packaged DMG currently copies
PhemyNative_PhemyNative.bundleonly into:But the generated runtime accessor first probes:
On a clean install that causes an immediate launch crash:
Fix
After copying the resource bundle into
Contents/Resources, also create an app-root symlink:This keeps the normal packaged resource location while restoring compatibility with the generated accessor in release builds.
Validation
scripts/create-dmg.shso future packaged apps include that symlink automaticallyRelated
Closes #1